Skip to content

fix(traces): align log table contents to start, regardless of height#112495

Merged
JoshuaKGoldberg merged 4 commits intomasterfrom
fix-trace-logs-table-flex-height
Apr 9, 2026
Merged

fix(traces): align log table contents to start, regardless of height#112495
JoshuaKGoldberg merged 4 commits intomasterfrom
fix-trace-logs-table-flex-height

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 8, 2026

The existing flex: 1 on TableContainer makes the table contents grow to fill their vertical space. When there aren't enough logs to fill the screen, by default flex-expand vertically. This adds align-contents: start so they're shoved into the beginning instead.

Example traces:

  • One log: sentry > f4ce570538e746b4b3ea9a745c51bdce
  • Three logs: sentry > 5eedb0ca1a5b43c18aaaeb9ad926f8ba
  • Ten logs: sentry > f8764c2c9c594eb6b47e4ee35b397277
  • Hundreds of logs: sentry > 64dbb2f1952742a0941ece5188ae07d5
  • Thousands of logs (thanks @k-fish!): sentry > a7988807ac5d496bafb9611c5626538b

Fixes LOGS-677

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 8, 2026
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 8, 2026

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 8, 2026 18:15
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team as a code owner April 8, 2026 18:15
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4dd6fd9. Configure here.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team as a code owner April 8, 2026 19:24
@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(traces): remove extra flex height stretch from logs table fix(traces): align log table contents to start, regardless of height Apr 8, 2026
@JoshuaKGoldberg JoshuaKGoldberg requested a review from k-fish April 8, 2026 19:41
@JoshuaKGoldberg JoshuaKGoldberg merged commit d0c0daf into master Apr 9, 2026
69 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix-trace-logs-table-flex-height branch April 9, 2026 12:17
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
…112495)

The existing `flex: 1` on `TableContainer` makes the table contents grow
to fill their vertical space. When there aren't enough logs to fill the
screen, by default flex-expand vertically. This adds `align-contents:
start` so they're shoved into the beginning instead.

Example traces:

* One log: sentry > `f4ce570538e746b4b3ea9a745c51bdce`
* Three logs: sentry > `5eedb0ca1a5b43c18aaaeb9ad926f8ba`
* Ten logs: sentry > `f8764c2c9c594eb6b47e4ee35b397277`
* Hundreds of logs: sentry > `64dbb2f1952742a0941ece5188ae07d5`
* Thousands of logs (thanks @k-fish!): sentry >
`a7988807ac5d496bafb9611c5626538b`

Fixes LOGS-677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants