Skip to content

fix(o11y): gate http and grpc specific modules in client_signals#5312

Merged
haphungw merged 3 commits intogoogleapis:mainfrom
haphungw:fix-http-guards
Apr 7, 2026
Merged

fix(o11y): gate http and grpc specific modules in client_signals#5312
haphungw merged 3 commits intogoogleapis:mainfrom
haphungw:fix-http-guards

Conversation

@haphungw
Copy link
Copy Markdown
Contributor

@haphungw haphungw commented Apr 7, 2026

Add missing feature guards within gax-internal for isolation between HTTP and gRPC transport layers.

Essentially fix build error for #5292.

@haphungw haphungw force-pushed the fix-http-guards branch 3 times, most recently from 3a52f1a to 408b2b3 Compare April 7, 2026 17:50
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.79%. Comparing base (9faf396) to head (d4a6e17).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5312   +/-   ##
=======================================
  Coverage   97.78%   97.79%           
=======================================
  Files         220      220           
  Lines       45834    45833    -1     
=======================================
+ Hits        44820    44821    +1     
+ Misses       1014     1012    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haphungw haphungw marked this pull request as ready for review April 7, 2026 18:12
@haphungw haphungw requested a review from a team as a code owner April 7, 2026 18:12
@haphungw haphungw changed the title fix(o11y): gate http-specific modules in client_signals fix(o11y): gate http and grpc specific modules in client_signals Apr 7, 2026
@haphungw haphungw merged commit 2e516df into googleapis:main Apr 7, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants