Skip to content

Es review pass 2#1213

Open
mariron42 wants to merge 10 commits intohuggingface:mainfrom
mariron42:es-review-pass-2
Open

Es review pass 2#1213
mariron42 wants to merge 10 commits intohuggingface:mainfrom
mariron42:es-review-pass-2

Conversation

@mariron42
Copy link
Copy Markdown

Summary

This follow-up PR fixes a few consistency issues in the Spanish translation of chapter 11:

  • translates remaining quiz answer options that were still in English
  • removes a stray TODO left in the LoRA code example
  • aligns the LoRA explanatory text with the actual SFTTrainer(..., peft_config=...) example

Files updated

  • chapters/es/chapter11/3.mdx
  • chapters/es/chapter11/4.mdx
  • chapters/es/chapter11/5.mdx

Why

These are small but visible fidelity issues relative to the English source. The goal is to keep the Spanish version fully localized and technically consistent with the original content.

Spanish coverage now reaches the full course structure, including chapter 12 and the updated TOC. Some sections still need deeper editorial review against the English source, and that refinement work is ongoing.
Restore omitted content in sections 3, 4, and 5 so the Spanish translation tracks the English source more closely.
@mariron42
Copy link
Copy Markdown
Author

Summary

This follow-up PR fixes a few consistency issues in the Spanish translation of chapter 11 and ensures the MDX code blocks are formatted to pass the repository quality check.

Changes

  • translated remaining quiz answer options that were still in English
  • removed a stray TODO left in the LoRA example
  • aligned the LoRA explanatory text with the actual SFTTrainer(..., peft_config=...) usage
  • reformatted the affected MDX code blocks to satisfy utils/code_formatter.py --check_only

Files updated

  • chapters/es/chapter11/3.mdx
  • chapters/es/chapter11/4.mdx
  • chapters/es/chapter11/5.mdx
  • chapters/es/chapter12/3b.mdx
  • chapters/es/chapter8/4_tf.mdx

Validation

  • utils/code_formatter.py --check_only passes locally with black==24.8.0

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@mariron42
Copy link
Copy Markdown
Author

Added my contributor credit in both places:

  • Spanish translation page (chapters/es/chapter1/1.mdx)
  • Original English languages table (chapters/en/chapter1/1.mdx, Spanish row)

@mariron42 mariron42 closed this Mar 24, 2026
@mariron42 mariron42 reopened this Mar 24, 2026
@mariron42
Copy link
Copy Markdown
Author

Hi @lewtun and @stevhliu, gentle ping on this PR.

It adds a large batch of Spanish chapters and updates across the course, plus the follow-up fixes needed for CI/docs preview.

Would appreciate a review when possible. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants