-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(envs): lazy env init + AsyncVectorEnv as default for n_envs > 1 #3274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 43 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
69eec9c
docs(benchmarks): add benchmark integration guide and standardize ben…
pkooij 5ad4c8f
refactor(envs): move dispatch logic from factory into EnvConfig subcl…
pkooij bfa0a0f
docs(benchmarks): clean up adding-benchmarks guide for clarity
pkooij 75d5e5b
fix link
pkooij 7abe5f7
fix task count
pkooij 1fad71c
fix: enable SmolVLA eval on LIBERO with custom camera mappings
pkooij d8e0eaa
fix: use direct AutoresetMode import for gymnasium compat
pkooij 0ea6aac
fix: handle gymnasium < 1.0 without AutoresetMode
pkooij 27bbb6b
refactor: revert policy changes, keep env-only camera mapping fixes
pkooij 8e07cab
Update docs/source/env_processor.mdx
pkooij fd99209
feat(envs): lazy env init + AsyncVectorEnv as default for n_envs > 1
pkooij dbc8c2e
fix: close envs between tasks to prevent worker process accumulation
pkooij aebc5e2
fix(eval): use task_description instead of task for language conditio…
pkooij 8a778c0
docs: update adding_benchmarks for async env changes
pkooij 5ec6119
feat(eval): batch_size=auto + faster env loading
pkooij 2c32c04
docs: add evaluation guide and update benchmarks doc
pkooij 43abbcc
docs(evaluation): remove benchmark table, rename section header
pkooij 03e1901
perf(eval): shared memory, observation passthrough, task prefetch
pkooij 12023f4
style: ruff format
pkooij 9a6ab6a
chore: revert env_processor.mdx changes (not part of this PR)
pkooij 6e6f76d
ci(benchmarks): add isolated integration tests for libero and metaworld
pkooij 61e2be8
ci(benchmarks): pin action hashes and use uv sync --locked
pkooij 07350f9
ci(benchmarks): trigger only on envs/ or lerobot_eval.py changes
pkooij dfd09c0
fix(ci): set LIBERO_DATA_FOLDER to bypass interactive stdin prompt
pkooij 42ef36e
docs(benchmarks): add CI smoke test step to adding_benchmarks guide
pkooij 841cbb0
fix(ci): pre-create libero config in Dockerfile to bypass stdin prompt
pkooij c24687d
fix(ci): use shell to create libero config instead of multiline pytho…
pkooij 2420d20
fix(ci): point libero config to bundled package init_files
pkooij 58a5bcb
fix(ci): add smolvla extra to benchmark Dockerfiles
pkooij f3853c9
fix(eval): render_frame covers _LazyAsyncVectorEnv
pkooij e35b485
refactor(envs): remove unused _get_sub_env_attr helper
pkooij 28d353e
chore: apply prettier formatting to docs
pkooij 527463c
docs(env_processor): remove deprecated add_envs_task from pipeline ex…
pkooij 606ed97
refactor(envs): remove __del__ from _LazyAsyncVectorEnv
pkooij 93b99e4
fix(eval): prefetch next task's workers after close to avoid GPU memo…
pkooij fe05e50
refactor(envs): move _LazyAsyncVectorEnv to utils and apply to metaworld
pkooij c8c2e88
chore: remove out-of-scope benchmark/CI/docs files from PR
pkooij f4bc9b5
chore: restore adding_benchmarks + test_dispatch, drop env_processor …
pkooij 5bc90c7
docs(adding_benchmarks): remove CI smoke test step (coming in separat…
pkooij 566a77b
refactor(envs): remove unused add_envs_task
pkooij 973bb7c
style: fix prettier formatting in env_processor.mdx
pkooij c3fa286
fix(eval): catch AttributeError and NotImplementedError explicitly fo…
pkooij 44534d5
fix(envs): use forkserver context and close envs in test to prevent d…
pkooij 7c9a676
fix(envs): default use_async_envs=False in create_envs and make_env
pkooij File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.