fix(dataset): patches torchvision transforms registration#3316
Open
fracapuano wants to merge 1 commit intohuggingface:mainfrom
Open
fix(dataset): patches torchvision transforms registration#3316fracapuano wants to merge 1 commit intohuggingface:mainfrom
fracapuano wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines how image transforms are managed for LeRobotDataset/DatasetReader, aligning with the “separation of concerns” goal from #3152 by moving transform mutation behind explicit reader APIs rather than directly touching private state.
Changes:
- Add
DatasetReader.set_image_transforms()/clear_image_transforms()and route initialization through the setter for consistent validation. - Update
LeRobotDatasetto validate/storeimage_transformsin the facade and propagate updates via the reader’s public setter (no direct_image_transformsaccess). - Add a regression test ensuring reader-level set/clear updates runtime behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/lerobot/datasets/dataset_reader.py |
Introduces reader-level transform setter/clear APIs and centralizes validation. |
src/lerobot/datasets/lerobot_dataset.py |
Validates/stores transforms on the facade and propagates via reader public methods. |
tests/datasets/test_dataset_reader.py |
Adds coverage for runtime transform updates/clearing on DatasetReader. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Patches comments from @imstevenpmwork on #3153
Type / Scope
Summary / Motivation
NA
Related issues
See #3152
What changed
LeRobotDatasetfacade and the newly introduced double Writer/Reader backends.How was this tested (or how to run locally)
Checklist (required before merge)
pre-commit run -a)pytest)Reviewer notes