fix(rules): ensure lookbehind regex is evaluated correctly by minifiers#3945
Open
christophe-g wants to merge 2 commits intomarkedjs:masterfrom
Open
fix(rules): ensure lookbehind regex is evaluated correctly by minifiers#3945christophe-g wants to merge 2 commits intomarkedjs:masterfrom
christophe-g wants to merge 2 commits intomarkedjs:masterfrom
Conversation
* Use a default variable in the regex to prevent removal by minifiers
|
@christophe-g is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the supportsLookbehind detection logic in src/rules.ts by introducing a default parameter to the detection function. This change prevents minifiers from potentially removing the regex evaluation during build-time optimization, ensuring the feature detection occurs correctly at runtime. There were no review comments provided, and I have no additional feedback to provide.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a default variable in the regex to prevent removal by minifiers.
This is a very minor change that fix #3944 downstream