Skip to content

fix(rules): ensure lookbehind regex is evaluated correctly by minifiers #3945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophe-g wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −3
Open

fix(rules): ensure lookbehind regex is evaluated correctly by minifiers #3945

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a6e5b0
fix(rules): ensure lookbehind regex is evaluated correctly by minifiers
christophe-g Apr 9, 2026
b360eaa
fix(rules): remove unnecessary eslint directive for lookbehind regex
christophe-g Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/rules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ function edit(regex: string | RegExp, opt = '') {
return obj;
}

const supportsLookbehind = (() => {
// use a default variable to ensure the regex is evaluated on client an not removed by minifiers
const supportsLookbehind = ((a = '') => {
try {
// eslint-disable-next-line prefer-regex-literals
return !!new RegExp('(?<=1)(?<!1)');
return !!new RegExp('(?<=1)(?<!1)' + a);
} catch {
// See browser support here:
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Regular_expressions/Lookbehind_assertion
Expand Down