Open
Conversation
thomas-bc
reviewed
Apr 10, 2026
Collaborator
thomas-bc
left a comment
thomas-bc
left a comment
There was a problem hiding this comment.
🎉 🐍 🎉
Looking good - a few recs
| Once added, users should install `fprime-python` into their Python environment. | ||
|
|
||
| ```bash | ||
| pip install lib/fprime-python |
Collaborator
There was a problem hiding this comment.
Making it clear it's a local path so the error is more meaningful if it's ran elsewhere
Suggested change
| pip install lib/fprime-python | |
| pip install ./lib/fprime-python |
| - A working F Prime development environment | ||
| - An understanding of how to create F Prime projects using F Prime libraries | ||
| - Basic familiarity with FPP and the generated C++ structure | ||
| - Working of Python development |
| pybind11::class_<ReferenceDeployment::TopologyState>(m, "TopologyState") | ||
| .def(pybind11::init<>()) | ||
| .def_readwrite("hostname", &ReferenceDeployment::TopologyState::hostname) | ||
| .def_readwrite("port", &ReferenceDeployment::TopologyState::port); |
Collaborator
There was a problem hiding this comment.
It could be good to link to a few specific docs of pybind11 here, or add a bit more details to the guide. I can guess at what's going on, but not much more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
How-To for F Prime Python.
Rationale
Community request.
Testing/Review Recommendations
Student review.
Future Work
AI Usage (see policy)
Autocomplete.