Skip to content

test: skip url WPT subtests instead of modifying test script#62635

Open
panva wants to merge 1 commit intonodejs:mainfrom
panva:test-wpt-url-skips
Open

test: skip url WPT subtests instead of modifying test script#62635
panva wants to merge 1 commit intonodejs:mainfrom
panva:test-wpt-url-skips

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Apr 8, 2026

Rather than modifying the test script this skips subtests that use <a> or <area>.

Building on #62517

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added test Issues and PRs related to the tests. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Apr 8, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 8, 2026
@panva panva added the web-standards Issues and PRs related to Web APIs label Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.76%. Comparing base (ae1c0e4) to head (6eba7f8).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62635      +/-   ##
==========================================
- Coverage   89.79%   89.76%   -0.03%     
==========================================
  Files         697      697              
  Lines      215773   215773              
  Branches    41297    41293       -4     
==========================================
- Hits       193749   193695      -54     
- Misses      14117    14161      +44     
- Partials     7907     7917      +10     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 8, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 8, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. web-standards Issues and PRs related to Web APIs whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants