Skip to content

test: skip url WPT subtests instead of modifying test script #62635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panva wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −26
Open

test: skip url WPT subtests instead of modifying test script #62635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions test/wpt/status/url.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
'use strict';

module.exports = {
'historical.any.js': {
'fail': {
'expected': [
'searchParams on location object',
],
},
},
'javascript-urls.window.js': {
'skip': 'requires document.body reference',
},
'percent-encoding.window.js': {
'skip': 'requires document.body reference',
},
'toascii.window.js': {
'skipTests': [
/\(using <a(rea)?>/,
],
},
'url-setters-a-area.window.js': {
'skip': 'already tested in url-setters.any.js',
},
};
18 changes: 0 additions & 18 deletions test/wpt/status/url.json
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions test/wpt/test-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,5 @@ const { WPTRunner } = require('../common/wpt');

const runner = new WPTRunner('url');

runner.setScriptModifier((obj) => {
if (obj.filename.includes('toascii.window.js')) {
// `a` and `area` in `toascii.window.js` is for testing `Element` that
// created via `document.createElement`. So we need to ignore them and just
// test `URL`.
obj.code = obj.code.replace(/\["url", "a", "area"\]/, '[ "url" ]');
}
});
runner.pretendGlobalThisAs('Window');
runner.runJsTests();
Loading