8372831: [lworld] com/sun/jdi/EATests.java#id0 fails with --enable-preview#2313
8372831: [lworld] com/sun/jdi/EATests.java#id0 fails with --enable-preview#2313plummercj wants to merge 3 commits intoopenjdk:lworldfrom
Conversation
|
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
|
@plummercj This change is no longer ready for integration - check the PR body for details. |
Webrevs
|
test/jdk/com/sun/jdi/EATests.java
Outdated
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2020, 2025 SAP SE. All rights reserved. | |||
| * Copyright (c) 2020, 2026 SAP SE. All rights reserved. | |||
There was a problem hiding this comment.
Unless the changes were contributed by SAP, I think we need an Oracle copyright line here.
Arraying
left a comment
There was a problem hiding this comment.
Except for the pending copyright comment, the test changes look fine. Thanks for investigating and fixing!
|
@dean-long @Arraying For anyone reviewing this PR, please also look at openjdk/jdk#30560. There are a few ways of addressing this issue and there isn't consensus yet on which way to go about it. openjdk/jdk#30560 (comment) is a good summary of the 4 possible ways I can envision addressing this issue. They all have different pros and cons. |
Don't run the
EARelockingValueBasedsubtest when using--enable-preview.The switch from
drivertomainis needed in order to get the test to run with preview enabled when it is specified.When value types move out of preview, the
EARelockingValueBasedtest will need to be removed.Progress
Error
- [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2313/head:pull/2313$ git checkout pull/2313Update a local copy of the PR:
$ git checkout pull/2313$ git pull https://git.openjdk.org/valhalla.git pull/2313/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2313View PR using the GUI difftool:
$ git pr show -t 2313Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2313.diff
Using Webrev
Link to Webrev Comment