Skip to content

8372831: [lworld] com/sun/jdi/EATests.java#id0 fails with --enable-preview #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plummercj wants to merge 3 commits into
base: lworld
Choose a base branch
from
+23 −13
Open

8372831: [lworld] com/sun/jdi/EATests.java#id0 fails with --enable-preview #2313

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e15ba5d
Don't run EARelockingValueBased when using --enable-preview
plummercj Apr 8, 2026
fbbdb08
remove tmp file
plummercj Apr 8, 2026
19d00c1
fix copyright
plummercj Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/jdk/ProblemList-enable-preview.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,3 @@
#############################################################################

# Valhalla failures start here:
com/sun/jdi/EATests.java#id0 8372831 generic-all
36 changes: 23 additions & 13 deletions test/jdk/com/sun/jdi/EATests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, 2025 SAP SE. All rights reserved.
* Copyright (c) 2020, 2026 SAP SE. All rights reserved.
Copy link
Copy Markdown
Member

@dean-long dean-long Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless the changes were contributed by SAP, I think we need an Oracle copyright line here.

Copy link
Copy Markdown
Contributor Author

@plummercj plummercj Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.

* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -28,38 +28,39 @@
* @summary Collection of test cases that check if optimizations based on escape analysis are reverted just before non-escaping objects escape through JVMTI.
* @author Richard Reingruber richard DOT reingruber AT sap DOT com
*
* @modules java.base/jdk.internal.misc
* @requires ((vm.compMode == "Xmixed") & vm.compiler2.enabled)
* @library /test/lib /test/hotspot/jtreg
*
* @run build TestScaffold VMConnection TargetListener TargetAdapter jdk.test.whitebox.WhiteBox
* @run driver jdk.test.lib.helpers.ClassFileInstaller jdk.test.whitebox.WhiteBox
* @run compile -g EATests.java
*
* @run driver EATests
* @run main EATests
* -XX:+UnlockDiagnosticVMOptions
* -Xms256m -Xmx256m
* -Xbootclasspath/a:.
* -XX:CompileCommand=dontinline,*::dontinline_*
* -XX:+WhiteBoxAPI
* -Xbatch
* -XX:+DoEscapeAnalysis -XX:+EliminateAllocations -XX:+EliminateLocks -XX:+EliminateNestedLocks
* @run driver EATests
* @run main EATests
* -XX:+UnlockDiagnosticVMOptions
* -Xms256m -Xmx256m
* -Xbootclasspath/a:.
* -XX:CompileCommand=dontinline,*::dontinline_*
* -XX:+WhiteBoxAPI
* -Xbatch
* -XX:+DoEscapeAnalysis -XX:+EliminateAllocations -XX:-EliminateLocks -XX:+EliminateNestedLocks
* @run driver EATests
* @run main EATests
* -XX:+UnlockDiagnosticVMOptions
* -Xms256m -Xmx256m
* -Xbootclasspath/a:.
* -XX:CompileCommand=dontinline,*::dontinline_*
* -XX:+WhiteBoxAPI
* -Xbatch
* -XX:+DoEscapeAnalysis -XX:-EliminateAllocations -XX:+EliminateLocks -XX:+EliminateNestedLocks
* @run driver EATests
* @run main EATests
* -XX:+UnlockDiagnosticVMOptions
* -Xms256m -Xmx256m
* -Xbootclasspath/a:.
Expand All @@ -70,7 +71,7 @@
*
* @comment Excercise -XX:+DeoptimizeObjectsALot. Mostly to prevent bit-rot because the option is meant to stress object deoptimization
* with non-synthetic workloads.
* @run driver EATests
* @run main EATests
* -XX:+UnlockDiagnosticVMOptions
* -Xms256m -Xmx256m
* -Xbootclasspath/a:.
Expand All @@ -84,7 +85,7 @@
* @comment Regression test for using the wrong thread when logging during re-locking from deoptimization.
*
* @comment DiagnoseSyncOnValueBasedClasses=2 will cause logging when locking on \@ValueBased objects.
* @run driver EATests
* @run main EATests
* -XX:+UnlockDiagnosticVMOptions
* -Xms256m -Xmx256m
* -Xbootclasspath/a:.
Expand All @@ -95,7 +96,7 @@
* -XX:DiagnoseSyncOnValueBasedClasses=2
*
* @comment Re-lock may inflate monitors when re-locking, which cause monitorinflation trace logging.
* @run driver EATests
* @run main EATests
* -XX:+UnlockDiagnosticVMOptions
* -Xms256m -Xmx256m
* -Xbootclasspath/a:.
Expand All @@ -107,7 +108,7 @@
*
* @bug 8341819
* @comment Regression test for re-locking racing with deflation with fast locking.
* @run driver EATests
* @run main EATests
* -XX:+UnlockDiagnosticVMOptions
* -Xms256m -Xmx256m
* -Xbootclasspath/a:.
Expand Down Expand Up @@ -159,6 +160,8 @@
import java.util.Map;
import java.util.function.Function;

import jdk.internal.misc.PreviewFeatures;

import jdk.test.lib.Asserts;
import jdk.test.whitebox.WhiteBox;
import jdk.test.whitebox.gc.GC;
Expand Down Expand Up @@ -259,7 +262,8 @@ public static void main(String[] args) {
new EAGetOwnedMonitorsTarget() .run();
new EAEntryCountTarget() .run();
new EARelockingObjectCurrentlyWaitingOnTarget() .run();
new EARelockingValueBasedTarget() .run();
// Cannot run EARelockingValueBased with value types enabled.
if (!PreviewFeatures.isEnabled()) new EARelockingValueBasedTarget() .run();

// Test cases that require deoptimization even though neither
// locks nor allocations are eliminated at the point where
Expand Down Expand Up @@ -302,10 +306,15 @@ public class EATests extends TestScaffold {
}

public static void main(String[] args) throws Exception {
int extra_args = 1;
if (EATestCaseBaseShared.RUN_ONLY_TEST_CASE != null) {
extra_args++;
}
args = Arrays.copyOf(args, args.length + extra_args);
if (EATestCaseBaseShared.RUN_ONLY_TEST_CASE != null) {
args = Arrays.copyOf(args, args.length + 1);
args[args.length - 1] = "-D" + EATestCaseBaseShared.RUN_ONLY_TEST_CASE_PROPERTY + "=" + EATestCaseBaseShared.RUN_ONLY_TEST_CASE;
args[args.length - extra_args--] = "-D" + EATestCaseBaseShared.RUN_ONLY_TEST_CASE_PROPERTY + "=" + EATestCaseBaseShared.RUN_ONLY_TEST_CASE;
}
args[args.length - extra_args] = "--add-exports java.base/jdk.internal.misc=ALL-UNNAMED";
new EATests(args).startTests();
}

Expand Down Expand Up @@ -385,7 +394,8 @@ protected void runTests() throws Exception {
new EAGetOwnedMonitors() .run(this);
new EAEntryCount() .run(this);
new EARelockingObjectCurrentlyWaitingOn() .run(this);
new EARelockingValueBased() .run(this);
// Cannot run EARelockingValueBased with value types enabled.
if (!PreviewFeatures.isEnabled()) new EARelockingValueBased() .run(this);

// Test cases that require deoptimization even though neither
// locks nor allocations are eliminated at the point where
Expand Down