Open
Conversation
- Docker 이미지 내부에 설정 파일을 고정하던 방식에서 벗어나, 외부 주입이 용이하도록 이미지를 경량화함.
- :latest 태그 의존성을 제거하고, 추적 가능한 SHA 태그를 사용하도록 개선 - .env 및 설정 생성 자동화
- 중복 컨테이너 구동 시 오작동 수정 - 대기 시간을 늘림
kyoooooong
approved these changes
Apr 14, 2026
kyoooooong
left a comment
kyoooooong
left a comment
There was a problem hiding this comment.
너무 아름다운 PR이네요..
바쁜 와중에 정말 너무너무 수고 많으셨습니다!! 👍
| ENV SPRING_PROFILES_ACTIVE=$SPRING_PROFILES_ACTIVE | ||
|
|
||
| CMD ["java", "-jar", "-Dspring.profiles.active=${SPRING_PROFILES_ACTIVE}", "-Dspring.config.location=file:/app/application-dev.yml", "app-application.jar"] | ||
| CMD ["java", "-jar", "app-application.jar"] No newline at end of file |
There was a problem hiding this comment.
이 부분은 Docker 이미지에 환경별 yml을 포함하지 않고, 실행 시점에 외부에서 주입하려고 이렇게 단순화하신 걸까요? 이미지 자체는 환경에 독립적으로 유지하려는 의도로 이해했습니다 👍 너무 좋아요!!
|
|
||
| echo "▶️ Start health check after 20 seconds" | ||
| sleep 20 | ||
| echo "▶️ Start health check after 30 seconds" |
There was a problem hiding this comment.
혹시 health check 대기 시간과 재시도 횟수를 늘리신 이유가 있으실까요? 그냥 너무 궁금해서 여쭤봅니다,, 👀
| GREEN_PORT=9091 | ||
|
|
||
| DOCKER_PS_OUTPUT=$(docker ps --format "{{.Names}}" | grep -E "(${BLUE_CONTAINER_NAME}|${GREEN_CONTAINER_NAME})" || true) | ||
| DOCKER_PS_OUTPUT=$(docker ps --format "{{.Names}}" | grep -E "(${BLUE_CONTAINER_NAME}|${GREEN_CONTAINER_NAME})" | head -n 1 || true) |
There was a problem hiding this comment.
오호 이건 여러 컨테이너 잡힐 때 딱 하나만 하는 용도인가요..?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Related ScreenShot 📷
To Reviewers 📢