-
Notifications
You must be signed in to change notification settings - Fork 1
[Chore] #710: 배포 파이프라인 변경 #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jher235
wants to merge
6
commits into
dev
Choose a base branch
from
chore/#710
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
20e6c26
[#710] chore: 컨테이너 삭제 명령어 추가
jher235 a0a05bf
[#710] refactor: Dockerfile 단순화 및 런타임 설정 주입 방식 개선
jher235 b7ea736
[#710] deploy: Dev/Prod 파이프라인에 Commit SHA 기반 이미지 태깅 도입 및 설정 파일 주입 방식 변경
jher235 135ff94
[#710] deploy: 배포 스크립트 안정성 강화 및 헬스체크 타임아웃 상향
jher235 26513ba
[#710] deploy: 이미지 태그를 github의 sha로 부여하도록 변경
jher235 12e46a4
[#710] deploy: 수동 실행이 가능하도록 옵션 추가
jher235 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,5 @@ | ||
| FROM amazoncorretto:21 | ||
| WORKDIR /app | ||
| COPY ./build/libs/app-server-0.0.1-SNAPSHOT.jar /app/app-application.jar | ||
| COPY ./src/main/resources/application-dev.yml /app/application-dev.yml | ||
|
|
||
| ARG SPRING_PROFILES_ACTIVE | ||
| ENV SPRING_PROFILES_ACTIVE=$SPRING_PROFILES_ACTIVE | ||
|
|
||
| CMD ["java", "-jar", "-Dspring.profiles.active=${SPRING_PROFILES_ACTIVE}", "-Dspring.config.location=file:/app/application-dev.yml", "app-application.jar"] | ||
| CMD ["java", "-jar", "app-application.jar"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,5 @@ | ||
| FROM amazoncorretto:21 | ||
| WORKDIR /app | ||
| COPY ./build/libs/app-server-0.0.1-SNAPSHOT.jar /app/app-application.jar | ||
| COPY ./src/main/resources/application-prod.yml /app/application-prod.yml | ||
|
|
||
| ARG SPRING_PROFILES_ACTIVE | ||
| ENV SPRING_PROFILES_ACTIVE=$SPRING_PROFILES_ACTIVE | ||
|
|
||
| CMD ["java", "-Dspring.profiles.active=${SPRING_PROFILES_ACTIVE}", "-Dspring.config.location=file:/app/application-prod.yml", "-jar", "app-application.jar"] | ||
| CMD ["java", "-jar", "app-application.jar"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ BLUE_PORT=9090 | |
| GREEN_CONTAINER_NAME="app-green" | ||
| GREEN_PORT=9091 | ||
|
|
||
| DOCKER_PS_OUTPUT=$(docker ps --format "{{.Names}}" | grep -E "(${BLUE_CONTAINER_NAME}|${GREEN_CONTAINER_NAME})" || true) | ||
| DOCKER_PS_OUTPUT=$(docker ps --format "{{.Names}}" | grep -E "(${BLUE_CONTAINER_NAME}|${GREEN_CONTAINER_NAME})" | head -n 1 || true) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 오호 이건 여러 컨테이너 잡힐 때 딱 하나만 하는 용도인가요..? |
||
| RUNNING_CONTAINER_NAME="${DOCKER_PS_OUTPUT:-}" | ||
|
|
||
| ALL_PORTS=("${BLUE_PORT}" "${GREEN_PORT}") | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 Docker 이미지에 환경별 yml을 포함하지 않고, 실행 시점에 외부에서 주입하려고 이렇게 단순화하신 걸까요? 이미지 자체는 환경에 독립적으로 유지하려는 의도로 이해했습니다 👍 너무 좋아요!!