fix(cmd): fix file descriptor leak from defer in loop#1154
Open
fix(cmd): fix file descriptor leak from defer in loop#1154
Conversation
Extract file creation and writing into writeFile() helper so that defer file.Close() runs per-call instead of accumulating until Run() returns. With many mock files, the previous code could exhaust OS file descriptor limits.
There was a problem hiding this comment.
Pull request overview
This PR addresses a potential OS file descriptor exhaustion in RootApp.Run() by ensuring file handles are closed per generated mock file rather than being deferred until the end of Run().
Changes:
- Introduces a
writeFile()helper to encapsulate create/write/close behavior. - Replaces the per-iteration
defer file.Close()in the mock-generation loop with a call towriteFile().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extract file creation and writing into writeFile() helper so that defer file.Close() runs per-call instead of accumulating until Run() returns. With many mock files, the previous code could exhaust OS file descriptor limits.
Type of change
Version of Go used when building/testing:
How Has This Been Tested?
Checklist