Skip to content

fix(cmd): fix file descriptor leak from defer in loop #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SVilgelm wants to merge 2 commits into
base: v3
Choose a base branch
from
+16 −9
Open

fix(cmd): fix file descriptor leak from defer in loop #1154

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a44906d
fix(cmd): fix file descriptor leak from defer in loop
SVilgelm Apr 2, 2026
b0e8c19
fix TestFoo
SVilgelm Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions internal/cmd/mockery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,18 @@ func (i *InterfaceCollection) Append(ctx context.Context, iface *internal.Interf
return nil
}

func writeFile(path string, data []byte) error {
f, err := os.Create(path)
if err != nil {
return stackerr.NewStackErr(err)
}
defer f.Close()
if _, err = f.Write(data); err != nil {
return stackerr.NewStackErr(err)
}
return nil
}

func (r *RootApp) Run() error {
remoteTemplateCache := make(map[string]*internal.RemoteTemplate)

Expand Down Expand Up @@ -374,13 +386,8 @@ func (r *RootApp) Run() error {
return fmt.Errorf("outfile exists")
}

file, err := os.Create(outFilePath)
if err != nil {
return stackerr.NewStackErr(err)
}
defer file.Close()
if _, err = file.Write(templateBytes); err != nil {
return stackerr.NewStackErr(err)
if err := writeFile(outFilePath, templateBytes); err != nil {
return err
}
}

Expand Down
Loading