Skip to content

Let tools/drake_visualizer work outside the sandbox#6319

Merged
jwnimmer-tri merged 2 commits intoRobotLocomotion:masterfrom
jwnimmer-tri:build-drake_visualizer-non-sandbox
Jun 12, 2017
Merged

Let tools/drake_visualizer work outside the sandbox#6319
jwnimmer-tri merged 2 commits intoRobotLocomotion:masterfrom
jwnimmer-tri:build-drake_visualizer-non-sandbox

Conversation

@jwnimmer-tri
Copy link
Copy Markdown
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jun 12, 2017

This fixes a few loose ends from #6259:

  • Let tools/drake_visualizer work outside the sandbox
  • Tidy up drake-visualizer launching in READMEs

All three of these methods have been tested to work:

bazel build //tools:drake_visualizer && ./bazel-bin/tools/drake_visualizer 
bazel run //tools:drake_visualizer 
bazel run //drake/automotive:demo

This change is Reviewable

@ggould-tri
Copy link
Copy Markdown
Contributor

+@ggould-tri


Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jamiesnape
Copy link
Copy Markdown
Contributor

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@ggould-tri
Copy link
Copy Markdown
Contributor

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@patmarion
Copy link
Copy Markdown
Member

By the way, this might indicate an issue with the precompiled drake-visualizer package. In the past, drake-visualizer has never required the user to set LD_LIBRARY_PATH or PYTHONPATH.

@jamiesnape
Copy link
Copy Markdown
Contributor

We are in a sandbox now and we are not using system installs of VTK.

@jwnimmer-tri
Copy link
Copy Markdown
Collaborator Author

Only non-Bazel builds remain. Using override-merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants