refactor(o11y): remove google-cloud-unstable-tracing guards and regenerate#5292
Draft
haphungw wants to merge 5 commits intogoogleapis:mainfrom
Draft
refactor(o11y): remove google-cloud-unstable-tracing guards and regenerate#5292haphungw wants to merge 5 commits intogoogleapis:mainfrom
google-cloud-unstable-tracing guards and regenerate#5292haphungw wants to merge 5 commits intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5292 +/- ##
==========================================
- Coverage 97.79% 97.78% -0.01%
==========================================
Files 220 220
Lines 45845 45829 -16
==========================================
- Hits 44832 44815 -17
- Misses 1013 1014 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
from
c86588b to
aaabb6e
Compare
This was referenced Apr 5, 2026
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
from
a1c2fd5 to
60b498d
Compare
haphungw
changed the title
google-cloud-unstable-tracing guards and regenerate
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
4 times, most recently
from
134dd05 to
98362b5
Compare
haphungw
added a commit
that referenced
this pull request
Apr 7, 2026
Restore the test to use `#[tokio::test(flavor = "multi_thread", worker_threads = 2)]` so the background server can run on a separate thread. I made a mistake when applying `#[tokio::test(flavor = "current_thread", start_paused = true)]` to `grpc_client_request_success`. This failed because: 1. This test does not contain any sleeps to optimize. 2. It starts a background gRPC server, which deadlocks on a single thread when the client waits for a response. This surfaces in #5292 when the `unstable_tracing` guards are removed.
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
3 times, most recently
from
706eb09 to
8accedb
Compare
haphungw
added a commit
that referenced
this pull request
Apr 7, 2026
Add missing feature guards within `gax-internal` for isolation between HTTP and gRPC transport layers. Essentially fix build error for #5292.
haphungw
added a commit
that referenced
this pull request
Apr 7, 2026
Fix a `gcb-pr-minimal-versions` build failure in `google-cloud-gax-internal` tests caused by `h2` version `0.4.2`, which surfaces after `google_cloud_unstable_tracing` guards are removed in #5292. The Problem During minimal-versions checks, `h2` resolves to `0.4.2`, which somehow leads to deadlocks or missing tracing spans in our gRPC tests. Previous Attempts I tried switching tests to `multi_thread` (PR #5308), which masked the issue but was not a good solution. I tried forcing the version in the root `[workspace.dependencies]`, but `Cargo` ignored it during the isolated package build for `gax-internal`. The Fix Add `h2 = "0.4.13"` as a direct dependency in `src/gax-internal/Cargo.toml`. `0.4.13` is the version resolved in our normal Cargo.lock.
haphungw
force-pushed
the
remove-google-cloud-unstable-tracing-guards
branch
from
8accedb to
2ad970b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.